Preparing docker image for v6 #208
Conversation
ildyria
commented
Sep 30, 2024
•
ildyria
commented
- make the temporary storage folders configurable/linkable.
Dockerfile
Outdated
| @@ -102,7 +105,7 @@ COPY --from=static_builder --chown=www-data:www-data /app/public /var/www/html/L | |||
| COPY default.conf /etc/nginx/nginx.conf | |||
|
|
|||
| EXPOSE 80 | |||
| VOLUME /conf /uploads /sym /logs | |||
| VOLUME /conf /uploads /sym /logs /image-tmp /image-jobs /extract-jobs | |||
There was a problem hiding this comment.
This feels excessive as they should all be temporary, but 🤷♂️
There was a problem hiding this comment.
They probably need permissions checks too
There was a problem hiding this comment.
Good point on permission checks.
yeah I know it feels excessive, but that way you may run your docker base container on a small instance and have some scratch pad for the tmp files. :)
There was a problem hiding this comment.
yeah I know it feels excessive, but that way you may run your docker base container on a small instance and have some scratch pad for the tmp files. :)
But do you need three separate ones? e.g. it could be /lychee-tmp/image-tmp etc? That would also save remapping if we add more or rename them again.
It's good enough to merge, just feels a bit much.
There was a problem hiding this comment.
But do you need three separate ones? e.g. it could be
/lychee-tmp/image-tmpetc? That would also save remapping if we add more or rename them again.It's good enough to merge, just feels a bit much.
Ohhh, good point, I like it!
I will fix that in v6.
There was a problem hiding this comment.
Could just cheat it here, but if there's a good place in the v6 too, sure :)
Co-authored-by: Martin Stone <[email protected]>
