Adds support for babel-module-resolver #5
Conversation
src/handlers/fileResolver.js
Outdated
| } | ||
|
|
||
| function checkBabelModuleResolver(filePath, currentFile) { | ||
| const loadedConfig = findBabelConfig.sync(currentFile); | ||
| if (loadedConfig) { |
There was a problem hiding this comment.
maybe also add some conditions if the config file does not contain plugins for example:
loadedConfig && loadedConfig.config.plugins
src/handlers/fileResolver.js
Outdated
| @@ -18,6 +39,10 @@ const resolveSync = enhancedResolve.create.sync({ | |||
| */ | |||
| function resolve(relPath = "", currentFile = "") { | |||
| const currentDir = path.dirname(currentFile); | |||
| if (!relPath.match(/^(\.|\/)/)) { | |||
There was a problem hiding this comment.
The responsibility of the method checkNodeModules is exactly the same as this condition, however checkNodeModules also checks for windows path too (for example, c:/),
I would suggest, instead of this condition use checkNodeModules. However the name checkNodeModules is not meaningful anymore, maybe rename it isAbsolutePath
There was a problem hiding this comment.
Just to be clear, are there any other options than these?
1) import foo from 'bar'
2) import foo from '../../../bar'
3) import foo from '/usr/local/npm/bar' # or 'c:/Users/foobar/npm/bar'
- refers to a node module OR a babel-resolved model
- is a relative path
- is an absolute path
There was a problem hiding this comment.
Yeah, I guess that it covers it all:)
Just one point the first case can also be webpack alias and package.json aliases too:)
There was a problem hiding this comment.
I found another case which is import foo from 'includes/bar which can be resolved by babel-module-resolver, so I had to change a bit this piece of code
There was a problem hiding this comment.
I found another case which is import foo from 'includes/bar which can be resolved by babel-module-resolver, so I had to change a bit this piece of code
There was a problem hiding this comment.
I found another case which is import foo from 'includes/bar which can be resolved by babel-module-resolver, so I had to change a bit this piece of code
src/handlers/fileResolver.js
Outdated
| @@ -18,6 +39,10 @@ const resolveSync = enhancedResolve.create.sync({ | |||
| */ | |||
| function resolve(relPath = "", currentFile = "") { | |||
| const currentDir = path.dirname(currentFile); | |||
| if (!relPath.match(/^(\.|\/)/)) { | |||
There was a problem hiding this comment.
Also about this if, I suggest moving it after line 53 inside catch phrase, in that way all the normal cases (1. relative imports, 2. node_modules imports) are handled first, then if it is not found there it can look for babel aliases
|
@leorossi Thank you for the amazing pull request, I think it is a really useful feature. |
leorossi
force-pushed
the
feature/support-babel-module-resolver
branch
from
b6497e5 to
7e083a3
Compare
|
@M-Izadmehr I added a |
leorossi
force-pushed
the
feature/support-babel-module-resolver
branch
from
7e083a3 to
6e7b3b3
Compare
|
@M-Izadmehr are there any updates on this one? |
|
Thanks @leorossi for the help. |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is a first attempt to solve #3
I used
babel-plugin-module-resolverandfind-babel-configto trigger babel plugin to resolve a file which is imported.I tested with a sample project but I am guessing there is still a little work to do.
I am checking in
fileResolver:42whether the file might be a local dependency, but actually this will be triggered even with aimport { something} from 'an-npm-package'Maybe this check should be done after we are sure it's not a node module?