-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/111: GH Action CICD #113
Conversation
deploy: | ||
name: Deploy | ||
needs: [ build, docker ] | ||
# runs-on: [${{ needs.build.outputs.deploy_env }}, self-hosted] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once merged to the proper repo this will be un-commented so I can test the self-hosted runner deployment
Were you able to verify that the new docker container (with poetry) works as expected locally ? |
Also, will the deploy step run on every push to a branch ? |
I was able to start the web service and bring up the swagger ui. I also verified it connected to my local db (which comes from the settings). But I don't have any local data or anything to verify application functionality; I would need some help to walk through that process.
Deploy will run automatically on every push to:
Build will run on every push to any tracked branch. Deploy can be manually triggered via workflow dispatch where you select the branch to deploy and which environment to deploy to. This allows a developer to deploy a feature branch they are working on to DIT for example. Additionally, there are restrictions setup in the repo settings which limit what branches can be deployed to which environment. Currently, DIT has no branch restrictions, UAT will only accept builds from |
I think I've got this working through deployment now in my fork. Here is an example run: https://github.com/frankinspace/maap-api-nasa/actions/runs/9393328409
The deploy step is failing at the moment because I don't have the self-hosted runner setup in my fork. So once we merge this I may still need to open up a follow-up PR for a bit more troubleshooting.
Work completed:
dit
,uat
, orops
), andlatest