-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ssh info #340
base: develop
Are you sure you want to change the base?
Update ssh info #340
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@wildintellect @rtapella Just following up on this PR |
@@ -6,7 +6,7 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these instructions correct. While they work I thought the preferred way was to upload your public key to the gitlab instance and manage from there?
Should we link to more univeral instructions on generating a key? Do we need to suggest a minimum bit depth of 2048 (perhaps 4096 would be better)
The mounting instructions should come at the end. Also this doesn't mention use of SFTP (via SCP or other clients like Filezilla) for doing file transfers without mounts.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the preferred way to upload your public key. I tried this method for uploading an ssh key to ops and it didn't work but it worked for a uwg member. These steps worked on DIT for me. I just tried uploading my ssh key to the maap gitlab instance and launching ops ade, but this still doesn't work
I just kept the same instructions on generating a key as before. How can we make it more universal? The instructions are for UNIX, UNIX-like and Windows
I am fine with suggesting 4096 for minimum bit depth
I am not sure the instructions for mounting or SFTP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions are pretty old. I feel like I copied at least some of this from Alexey's quickstart guide, and maybe some was in ReadtheDocs before that? I don't mind overhauling this a bit if we need to.
I think demonstrating easier ways to move files in/out of your workspace would be helpful.
I think that whatever we suggest in the docs could become the standard. I don't know anything about putting the public key into Gitlab. Maybe this is a good dev team topic to work out what we want to standardize on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can discuss at hackathon on 10/25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any update? I know there were some recent fixes to the process by @bsatoriu @sujen1412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsatoriu thinks our minimum bit depth is 512, and also doesn't have a preference suggesting 2048 over 4096
Brian also fixed some bugs that are going to be released in January, I can test uploading my public key via the portal once these changes are released and then modify the docs from there (one of the bugs was uploading the public key to the MAAP portal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Min bit depth should be 2048, 1024 and lower are brute force hackable (I forget if it's both DSA and RSA or just one). Maybe just say recommended is 4096
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, just added bit depth recommendation
I added it to the Profile and to ~/.ssh/authorized_keys and logged out/in to refresh everything. I also stopped and started the workspace. Still "Connection refused" |
This documentation PR is still being blocked by: MAAP-Project/Community#849 |
Updating information about getting ssh info after getting question from Tempest McCabe
Although, the process didn't work for me and is still a comment on https://docs.google.com/document/d/1RLtkgxQmCsPQFh0H402THG-WwmL5_syC69tNT6VUSmc/edit?usp=sharing
But Tempest said adding ssh worked for her