Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/container url dropdown #155

Merged
merged 16 commits into from
Dec 10, 2024
Merged

Conversation

grallewellyn
Copy link
Contributor

algorithm extension 0.3.7 is the container dropdown url feature update and 0.3.8 is the documentation link fix

Resolved through these PRs into the extensions: MAAP-Project/jupyter-server-extension#15
MAAP-Project/algorithms-jupyter-extension#16
MAAP-Project/algorithms-jupyter-extension#17
More information in the PRs

Fixes: MAAP-Project/Community#930
MAAP-Project/Community#1056

Can test with this image: 'mas.dit.maap-project.org/root/maap-workspaces/jupyterlab/python:container-url-dropdown'

@grallewellyn
Copy link
Contributor Author

@sujen1412 Do we want to be using 'mas.dit.maap-project.org/root/maap-workspaces/custom_images/maap_base:develop' for the default docker image? Registering an algorithm with it fails: https://repo.dit.maap-project.org/root/register-job/-/jobs/16332

@grallewellyn
Copy link
Contributor Author

Based on this build, it seems like 'mas.dit.maap-project.org/root/maap-workspaces/custom_images/maap_base:develop' is correct

This is registering the same algorithm but with
'mas.dit.maap-project.org/root/maap-workspaces/custom_images/maap_base:develop', the build fails
'mas.dit.maap-project.org/root/maap-workspaces/base_images/python:develop', the build is successful

I created this ticket: MAAP-Project/Community#1143 to track fixing the maap_base image

@grallewellyn
Copy link
Contributor Author

I am going to merge this because MAAP-Project/Community#1143 is a separate issue and 'mas.dit.maap-project.org/root/maap-workspaces/custom_images/maap_base:develop' is the image that I should be using

@grallewellyn grallewellyn merged commit 049f0cf into develop Dec 10, 2024
@grallewellyn grallewellyn deleted the feature/container-url-dropdown branch December 10, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants