breaking up mousemoved function in all QtPlotter classes and cleaning up some random stuff too #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up some random stuff too
Pull Request Test Coverage Report for Build 119
💛 - Coveralls |
|
Sorry to do this to you, but it looks like all the changes I recently made kinda mess with merging this. Its still a good idea to do this, but I got rid of the mouse moved function in each plot and changed basically all TVar attributes so that they are encapsulated inside of pytplot.data_quants['var1'].attrs["plot_attributes"]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #57
Just broke up the mousemoved functions in all the QtPlotter classes to try and be a bit more condensed in what they do. Moved the actual drawing of crosshairs/setting crosshair legend options outside of the mousemoved functions.