Refactor Popular Logic (again) #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifiy the span during which popular suggestions affect the requirement, and change the maximum from 23 to a bot constant (35).
|
Quick note, someone please look over the changes in case I made a mistake somewhere, as this is incredibly hard to test without 30+ alts and 2 weeks of time. |
Owen1212055
reviewed
Aug 27, 2022
Comment on lines
19
to
24
| ratio = BotConstants.MIN_RATIO + (int) set.getInt("recents")) ; | ||
| if (ratio < BotConstants.MIN_RATIO) { | ||
| ratio = BotConstants.MIN_RATIO; | ||
| } | ||
| if (ratio > BotConstants.MAX_RATIO) { | ||
| ratio = BotConstants.MAX_RATIO |
There was a problem hiding this comment.
Do something like
Math.min(BotConstants.MIN_RATIO, Math.min(ratio, BotConstants.MAX_RATIO))Small change to remove ifs
RedDaedalus
approved these changes
Aug 27, 2022
Owen1212055
requested changes
Aug 27, 2022
src/main/java/com/diamondfire/suggestionsbot/suggestions/reactions/PopularHandler.java
Outdated
Show resolved
Hide resolved
Min -> Max
Owen1212055
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifiy the span during which popular suggestions affect the requirement, and change the maximum from 23 to a bot constant (35).