Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos #147

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Add logos #147

merged 5 commits into from
Jun 21, 2024

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Jun 16, 2024

First attempt at adding logos. Is the favicon too blurry and hard to make out?

How should we license the logo as well? Are we happy with the same license as the MDAnalysis one?

I'll add the final SVGs and exports at different ppi to the branding repository, but just checking we don't want to make last minute changes.

Logo:

Screenshot 2024-06-16 at 7 02 00 pm

Favicon on dark:
Screenshot 2024-06-16 at 7 02 35 pm

Favicon on light:

Screenshot 2024-06-16 at 7 03 12 pm

@lilyminium lilyminium marked this pull request as ready for review June 16, 2024 09:04
@IAlibay
Copy link
Member

IAlibay commented Jun 16, 2024

Thanks, will look into this a bit more later - reminder for self, the logo is derivative of old logo, which means that we need to check the rules on licensing for derivatives, it at the very least likely inherits something from the original license.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic. I am happy with it as is.

About license: NF is now holding the rights for the MDAnalysis logo but we can create derivatives for our own use. I will check with them how to change the license information MDAnalysis/branding#6

For right now, we are safe by just not adding any license: @lilyminium is the author and used the MDA logo; as long as we don't provide a license, no-one can use it.

We are not applying this logo to kits (right??) so I think we are fine for right now. Please block if otherwise.

@orbeckst
Copy link
Member

orbeckst commented Jun 16, 2024

How about we use the empty gears as the default logo for kits?

EDIT: ... and encourage people to put their own logo inside the gears?

@lilyminium
Copy link
Member Author

Error when evaluating 'strategy' for job 'mdakit-ci'. .github/workflows/gh-ci.yaml (Line: 64, Col: 17): Matrix vector 'mdakit' does not contain any values

CI might be failing since this doesn't actually change any MDAKits.

@IAlibay
Copy link
Member

IAlibay commented Jun 17, 2024

Error when evaluating 'strategy' for job 'mdakit-ci'. .github/workflows/gh-ci.yaml (Line: 64, Col: 17): Matrix vector 'mdakit' does not contain any values

CI might be failing since this doesn't actually change any MDAKits.

yeah that's an ok failing - not the issue we're seeing in cron.

@lilyminium
Copy link
Member Author

Thanks for the reviews everyone!

@lilyminium lilyminium merged commit 3eb782c into main Jun 21, 2024
3 checks passed
@lilyminium lilyminium deleted the add-logo branch June 21, 2024 07:38
@orbeckst
Copy link
Member

Reading our trademark assignment contract, we are also assigning the rights to all new logos that we create for the project to NF so the MDAKits logo itself will also be governed by the same policies as the MDAnalysis logo itself.

I suggest we consider the "empty gears" a template and make that available under CC-BY or CC0.

@lilyminium
Copy link
Member Author

Thanks @orbeckst! I'll likely be adding it to the cookiecutter-mdakit and branding repositories (first doing so in the cookiecutter here MDAnalysis/cookiecutter-mdakit#120) instead of the MDAKits repo. I'll make clear that it's a template / placeholder, and add an additional license for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants