Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the right project slug on the rtd.yaml action #323

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Sep 22, 2023

The action isn't as relevant now that RTD points back to the build by default, but it still helps new users know where the build is (rather than searching through check links).


📚 Documentation preview 📚: https://mdanalysis--323.org.readthedocs.build/en/323/

@lilyminium
Copy link
Member

LGTM I think -- does it only update after merge? The top level comment still points to MDA

@lilyminium
Copy link
Member

Or is it mdanalysisuserguide?

@IAlibay
Copy link
Member Author

IAlibay commented Sep 22, 2023

LGTM I think -- does it only update after merge? The top level comment still points to MDA

Yeah it's a pull_request_trigger workflow so it'll only pick up what's merged.

@IAlibay
Copy link
Member Author

IAlibay commented Sep 22, 2023

Or is it mdanalysisuserguide?

Might be, let me double check

@IAlibay
Copy link
Member Author

IAlibay commented Sep 22, 2023

Yeah my bad, it's the rtd project name not the repo name - fixed.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No point waiting on tests then -- thanks @IAlibay!

@lilyminium lilyminium merged commit 455ec28 into develop Sep 22, 2023
3 checks passed
@lilyminium lilyminium deleted the fix-rtd-yaml branch September 22, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants