Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit info to quickstart #331

Merged
merged 3 commits into from
Sep 29, 2023
Merged

added unit info to quickstart #331

merged 3 commits into from
Sep 29, 2023

Conversation

micaela-matta
Copy link
Contributor

@micaela-matta micaela-matta commented Sep 29, 2023

Added a note and link to the MDAnalysis Units and Constants page to the Quickstart Guide


📚 Documentation preview 📚: https://mdanalysisuserguide--331.org.readthedocs.build/en/331/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

doc/source/examples/quickstart.ipynb Outdated Show resolved Hide resolved
@lilyminium
Copy link
Member

Thanks for opening this @micaela-matta! I just suggested a fix to the link but otherwise it looks great to me. Since this is your first commit to the repository, could you please add yourself to AUTHORS too? https://github.com/MDAnalysis/UserGuide/blob/develop/doc/source/AUTHORS

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for fixing that @micaela-matta!

@lilyminium lilyminium merged commit be6e4da into develop Sep 29, 2023
2 of 3 checks passed
@lilyminium lilyminium deleted the units branch September 29, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants