Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pseudo auto-generated notes for the 2.x+ release branch #339

Merged
merged 18 commits into from
Oct 27, 2023
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 1, 2023

Fixes #338

Alternatively we could just link to the blog posts.

Note: this does add to the maintenance burden, so we should be wary of this a bit.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 1, 2023

Sigh.. of course the formatting for releases isn't correctly done.
I'll go ahead and fix the release notes upstream.

@IAlibay IAlibay changed the title Try auto-generated notes for the 2.x+ release branch Add pseudo auto-generated notes for the 2.x+ release branch Oct 1, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Oct 1, 2023

Ok that should be it - see the original issue #338 for a reasoning as to why I don't think we can make this automatic right now.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAlibay, LGTM! I only have one small comment/question.

doc/source/scripts/gen_release_notes.py Outdated Show resolved Hide resolved
@IAlibay IAlibay requested a review from RMeli October 3, 2023 16:41
@RMeli
Copy link
Member

RMeli commented Oct 27, 2023

Thanks @IAlibay. Somehow I missed the re-review request.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

pre-commit isn't behaving, probably didn't do the combination properly

@IAlibay IAlibay merged commit a6fd626 into develop Oct 27, 2023
3 of 4 checks passed
@IAlibay IAlibay deleted the releases branch October 27, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visible release updates info
2 participants