Remove x86 pin setup-miniconda #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be forcing some kind of x86 compatibility build of Python on osx-arm64, removing makes the action pick up the right installer. You can see this action for more details: https://github.com/MDAnalysis/mdahole2/actions/runs/10024096447/job/27705759572
IAlibay
added a commit
to MDAnalysis/transport-analysis
that referenced
this pull request
Jul 22, 2024
4 tasks
IAlibay
added a commit
to MDAnalysis/waterdynamics
that referenced
this pull request
Jul 22, 2024
4 tasks
IAlibay
added a commit
to MDAnalysis/mdaencore
that referenced
this pull request
Jul 22, 2024
4 tasks
IAlibay
added a commit
to MDAnalysis/PathSimAnalysis
that referenced
this pull request
Jul 22, 2024
4 tasks
IAlibay
added a commit
to MDAnalysis/waterdynamics
that referenced
this pull request
Jul 22, 2024
* Remove x86_64 env build pin See: MDAnalysis/cookiecutter-mdakit#134 * Update requirements.yaml
IAlibay
added a commit
to MDAnalysis/mdaencore
that referenced
this pull request
Jul 22, 2024
RMeli
approved these changes
Jul 22, 2024
RMeli
reviewed
Jul 22, 2024
| @@ -65,7 +65,6 @@ jobs: | |||
| python-version: {{ '${{ matrix.python-version }}' }} | |||
| environment-file: devtools/conda-envs/test_env.yaml | |||
| add-pip-as-python-dependency: true | |||
| architecture: x64 | |||
There was a problem hiding this comment.
For other reviewers: x64 is a shorthand for x86_64.
|
Thanks @RMeli - it's a small change so I'll go with one review for merge. |
orbeckst
pushed a commit
to MDAnalysis/PathSimAnalysis
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be forcing some kind of x86 compatibility build of Python on osx-arm64, removing makes the action pick up the right installer.
You can see this action for more details: https://github.com/MDAnalysis/mdahole2/actions/runs/10024096447/job/27705759572