Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to distopia < 0.3 ahead of v2.8.0 release #4739

Closed
IAlibay opened this issue Oct 18, 2024 · 5 comments · Fixed by #4740
Closed

Pin to distopia < 0.3 ahead of v2.8.0 release #4739

IAlibay opened this issue Oct 18, 2024 · 5 comments · Fixed by #4740
Assignees
@orbeckst
Labels
Priority-High upstream issue in a dependency
Milestone
Release 2.8.0

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 18, 2024

Full deps CI is currentlly failling because of distopia's latest release.

We should pin the upper bound in the code checks to make sure that this doesn't hit users on release.
@orbeckst orbeckst added Priority-High upstream issue in a dependency labels Oct 18, 2024
@orbeckst
Copy link
Member

yes, eg PR #4737 is now failing due to this issue so we need at least a quick fix to be able to work on PRs.

@orbeckst orbeckst added this to the Release 2.8.0 milestone Oct 18, 2024
@orbeckst orbeckst changed the title Pin to distopia < 0.3 ahead of v2.8.0 releease Pin to distopia < 0.3 ahead of v2.8.0 release Oct 18, 2024
@orbeckst
Copy link
Member

Presumable PR #4734 should fix this?

This was referenced Oct 18, 2024
Open
Merged
@IAlibay
Copy link
Member Author

IAlibay commented Oct 18, 2024

Presumable PR #4734 should fix this?

Yes but I don't think a WIP should be on the release milestone? At least not if we're planning a release at the end of the weekend.

@orbeckst
Copy link
Member

That would seem ambitious and that was not what I wanted to suggest. I wanted to provide some context because it initially looked to me as if no-one was aware of what needs doing.

@orbeckst
Copy link
Member

Oh, I think now I see how you understood my comment. Let me rephrase

Presumable PR #4734 should fix this?

to

Let's pin distopia<0.3.0 as suggested in this issue so that CI runs again and so that we can get 2.8.0 out on time. But I hope that PR #4734 will soon be done so that we can then remove the pin and use the latest version of distopia (presumably it will have to be >= 0.3.0).

@orbeckst orbeckst self-assigned this Oct 18, 2024
orbeckst added a commit that referenced this issue Oct 18, 2024
@orbeckst
pin distopia<0.3.0
43f83b4 
- fix  #4739
- temporarily restrict distopia to >=0.2.0,<0.3.0 until MDAnalysis has
  caught up with distopia API changes
- updated CHANGELOG
@orbeckst orbeckst mentioned this issue Oct 18, 2024
Merged
8 tasks
orbeckst added a commit that referenced this issue Oct 18, 2024
@orbeckst
pin distopia<0.3.0
e60f3d5 
- fix  #4739
- temporarily restrict distopia to >=0.2.0,<0.3.0 until MDAnalysis has
  caught up with distopia API changes
- updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orbeckst orbeckst

Labels
Priority-High upstream issue in a dependency
Projects
None yet
Milestone
Release 2.8.0
Development

Successfully merging a pull request may close this issue.

pin distopia<0.3.0 MDAnalysis/mdanalysis
2 participants
@orbeckst @IAlibay