fix: Fixed handling of no-updates flag

MESH-Research · Nov 7, 2024 · f0553ff · f0553ff
1 parent 8df0c85
commit f0553ff
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/invenio_record_importer_kcworks/errors.py b/invenio_record_importer_kcworks/errors.py
@@ -73,6 +73,15 @@ def __init__(self, message):
         self.message = message
 
 
+class NoUpdates(Exception):
+    """No updates error."""
+
+    def __init__(self, message):
+        """Initialize the exception."""
+        super(NoUpdates, self).__init__(message)
+        self.message = message
+
+
 class PublicationValidationError(Exception):
     """Publication validation error."""
 

diff --git a/invenio_record_importer_kcworks/record_loader.py b/invenio_record_importer_kcworks/record_loader.py
@@ -28,6 +28,7 @@
 from invenio_record_importer_kcworks.errors import (
     DraftDeletionFailedError,
     ExistingRecordNotUpdatedError,
+    NoUpdates,
     PublicationValidationError,
     SkipRecord,
     UpdateValidationError,
@@ -305,9 +306,9 @@ def create_invenio_record(
                         f" record: {differences['B']}"
                     )
                     if no_updates:
-                        raise RuntimeError(
+                        raise NoUpdatesError(
                             "no_updates flag is set, so not updating existing"
-                            " record"
+                            " record with changed metadata..."
                         )
                     update_payload = existing_metadata.copy()
                     for key, val in differences["B"].items():
@@ -1475,6 +1476,7 @@ def load_records_into_invenio(
                     "TooManyViewEventsError": msg,
                     "TooManyDownloadEventsError": msg,
                     "UpdateValidationError": msg,
+                    "NoUpdatesError": msg,
                 }
                 log_object = {
                     "index": current_record,
@@ -1488,7 +1490,7 @@ def load_records_into_invenio(
                     log_object.update(
                         {"reason": error_reasons[e.__class__.__name__]}
                     )
-                if e.__class__.__name__ != "SkipRecord":
+                if e.__class__.__name__ not in ["SkipRecord", "NoUpdates"]:
                     failed_records, residual_failed_records = (
                         _log_failed_record(
                             **log_object, skipped_records=skipped_records