-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHUB/IDC - Implementing the Prostate158 whole prostate gland segmentation model available in MONAI (T2 only) #71
Conversation
I finished the implementation of the prostate158 model in mhub.ai configuration. Generated outputs are conform with my study. Instructions for testing can be found here -- .md file. @kbressem The meta information for the model is located here. The default workflow applies the same center-cropping strategy as defined in the prostate158 model training process. For DICOM SEG conversion purposes, the output segmentation file is padded back to the original (pre-centering) image size. This center-cropping strategy is a parameter of the Prostate158Runner, and can be changed to False. @LennyN95 Please let me know whenever you have a minute if my testing procedure is enough or needs to be extended/modified, thank you! |
The meta information seems all correct to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall. Some small issues to be adressed.
removed commented code
delete center_crop = True argument, since its enabled by default renamed model_name in DsegConverter
added external evaluation tables and references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed changes.
changed seg output name and added '%Modality' filter
added license information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed changes and added/modified model code based on @LennyN95 suggestions.
Looking good. @ccosmin97 shall we proceed with testing? If you feel ready, you can create a /test comment as described in our documentation here. |
Ok thanks @LennyN95 I will provide testing results later today. |
/test sample:
idc_version: 17.0
data:
- SeriesInstanceUID: 1.3.6.1.4.1.14519.5.2.1.7311.5101.117787454837907188090392680606
aws_url: s3://idc-open-data/4a15953b-3e16-4aa3-beb3-53187d84b6ed/*
path: dicom
reference:
url: https://www.dropbox.com/scl/fi/j6ouks1vqfeofaek8n3dk/output.zip?rlkey=y0p4b9pi2ot099iyxcjiqpdoj&dl=0 Test Results (24.03.06_09.47.47_ROPNerVqB9)id: a09b9f72-406f-47dd-bd38-ab883380bc8b
date: '2024-03-06 09:51:53'
checked_files:
- file: monai_prostate158.seg.dcm
path: /app/test/src/1.3.6.1.4.1.14519.5.2.1.7311.5101.117787454837907188090392680606/monai_prostate158.seg.dcm
checks:
- checker: DicomsegContentCheck
notes:
- label: Segment Count
description: The number of segments identified in the inspected dicomseg file.
info: 2
summary:
files_missing: 0
files_extra: 0
checks:
DicomsegContentCheck:
files: 1
conclusion: true |
FYI However, running: Any idea why this is happening? A mistake on my end? |
@ccosmin97 The docker-image needs to be declared after all docker run arguments. Any argument after the image name will be passed to the entry point ( The syntax is: Note that when performing a test run, there must be no mhub.run argument set! |
Adding template for PR request