-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate body part regression #98
base: main
Are you sure you want to change the base?
Conversation
Please note, we updated our base image. All mhub dependencies are now installed in a virtual environment under We also simplified our test routine. Sample and reference data now have to be uploaded to Zenodo and provided in a mhub.tom file at the project root. The process how to create and provide these sample data is explained in the updated testing phase article of our documentation. Under doi.org/10.5281/zenodo.13785615 we provide sample data as a reference. |
If we parse the BPE results in MHub value outputs (using the dedicated IO decorators) the output format can be customized through a report exporter. What do you think? |
@LennyN95 I'll take a look at this! I'm thinking Deepa might having something that we can use here as well as she did BPR -> Structured Report. But maybe we get in the first json version of this integrated and then add a workflow. I'll add tests based on the update! |
@LennyN95 I'm running into some challenges with the python environment for body part regression. I will debug this further and see. I think it might be better to use a custom fork with updated dependencies. Is there an mhub policy on this? |
I think this is from the new mhub container. Was there an OS upgrade as well? I've tried to use Python3.8 - which it worked on earlier but breaks now |
No so far I only updated Python. Have you tried installing bpr into a separate environment? |
I have yes - on two separate machines but both of them have had OS upgrades in the past weeks so I was attributing it to that. But now I am not sure anymore. |
@LennyN95 I've added a test for the default workflow but it seems like the compliance check fails because I haven't added tests for other workflows. Is this intended? Any way I can skip and only add tests for default as before? |
Switching base branch.
Original PR: #85