-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show before/after images in github #92
Conversation
Walkthroughこの変更では、 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (7)
README.md (7)
Line range hint
29-29
: 文中のコンマが抜けている可能性があります。「GTFS tables has routes-data and stops-data but tables-structure is somewhat complicated.」を「GTFS tables has routes-data and stops-data, but tables-structure is somewhat complicated.」に修正することをお勧めします。Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Line range hint
36-36
: 「time-table」は一語で書くのが一般的です。修正をお勧めします。Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Line range hint
39-39
: 「each lines」は「each line」と単数形であるべきです。また、「on left side」を「on the left side」と修正することをお勧めします。Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Line range hint
62-62
: 「new stop_id is parent's one」を「new stop_id is the parent's one」と修正することをお勧めします。また、「by defining delimiter, split stop_name into prefix and suffix, group same prefix stops」を「by defining a delimiter, split stop_name into prefix and suffix, and group same prefix stops」と修正することをお勧めします。Also applies to: 66-66
Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Line range hint
82-82
: 「Thank you for great contributions!」を「Thank you for the great contributions!」に修正することをお勧めします。Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Line range hint
102-102
: コードブロックに言語指定が必要です。例えば、Pythonの場合は ```python と記述します。Also applies to: 106-106
Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Line range hint
9-9
: 画像には代替テキスト(alt text)を設定することが推奨されます。これにより、画像が表示されない場合や視覚障害のあるユーザーが利用する際に役立ちます。Also applies to: 10-10, 14-14, 27-27, 34-34, 49-49, 53-53, 78-78
Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional context used
LanguageTool
README.md
[uncategorized] ~29-~29: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...FS tables has routes-data and stops-data but tables-structure is somewhat complicate...
[misspelling] ~36-~36: This word is normally spelled as one. (EN_COMPOUNDS_TIME_TABLE)
Context: ...ng" width="80%"> GTFS also has service time-table information. This plugin can aggregate ...
[grammar] ~39-~39: The noun should probably be in the singular form. (EVERY_EACH_SINGULAR)
Context: ...with lines indicate a frequency of each lines, set on left side towards direction of ...
[uncategorized] ~39-~39: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...icate a frequency of each lines, set on left side towards direction of path (UK traf...
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...
[uncategorized] ~62-~62: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...nto parent station - new stop_id is parent's one 2. stop_id prefix - by defi...
[uncategorized] ~66-~66: You might be missing the article “a” here. (AI_EN_LECTOR_MISSING_DETERMINER_A)
Context: ...e 2. stop_id prefix - by defining delimiter, split stop_name into prefix and suffix...
[uncategorized] ~82-~82: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...in](https://t-brain.jp/). Thank you for great contributions! ## Contribution ### Tr...
Markdownlint
README.md
102-102: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
106-106: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
9-9: null (MD045, no-alt-text)
Images should have alternate text (alt text)
10-10: null (MD045, no-alt-text)
Images should have alternate text (alt text)
14-14: null (MD045, no-alt-text)
Images should have alternate text (alt text)
27-27: null (MD045, no-alt-text)
Images should have alternate text (alt text)
34-34: null (MD045, no-alt-text)
Images should have alternate text (alt text)
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
78-78: null (MD045, no-alt-text)
Images should have alternate text (alt text)
Additional comments not posted (1)
README.md (1)
49-53
: 画像パスの更新が正しく行われています。Tools
Markdownlint
49-49: null (MD045, no-alt-text)
Images should have alternate text (alt text)
53-53: null (MD045, no-alt-text)
Images should have alternate text (alt text)
|
||
- after | ||
|
||
<img src="doc_imgs/frequency3.png" width="80%"> | ||
<img src="doc_imgs/frequency3.png" width="80%"> | ||
|
||
#### stops unifying rules | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「Smaller number of rules is prefered.」を「A smaller number of rules is preferred.」に修正することをお勧めします。また、「prefered」は「preferred」の誤字です。
Tools
LanguageTool
[uncategorized] ~56-~56: A determiner appears to be missing. Consider inserting it. (AI_EN_LECTOR_MISSING_DETERMINER)
Context: ...idth="80%"> #### stops unifying rules Smaller number of rules is prefered. 1. parent...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for contribution!
Description(変更内容)
Manual Testing(手動テスト)
Not required / 不要
Summary by CodeRabbit
README.md
内の画像パスをfrequency2.png
からfrequency3.png
に更新しました。