Feature/fix sonar1

.github/workflows/build.yml

@@ -0,0 +1,37 @@
+name: Build
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  sonarcloud:
+    name: SonarCloud
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Setup Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: '3.7'
+      - name: Version de Python
+        run: |
+          python --version
+      - name: Instalación de librerías y dependencias
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt
+      - name: pruebas+coverage
+        id: pruebas
+        run: |
+          python -m coverage run -m unittest discover -s tests -v
+          coverage report
+          python -m coverage xml -i
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.gitignore

@@ -3,3 +3,5 @@ src/modelo/__pycache__/*
 src/logica/__pycache__/*
 src/vista/__pycache__/*
 venv/*
+tests/__pycache__/*
+aplicacion.sqlite

sonar-project.properties

@@ -0,0 +1,16 @@
+sonar.projectKey=tom-uniandes_TutorialCancionesTags
+sonar.organization=tom-uniandes
+
+sonar.coverage.exclusions=**tests/**,**src/vista/**,**src/recursos/**,**docs/**,**setup.py**
+sonar.python.coverage.reportPaths=coverage.xml
+
+# This is the name and version displayed in the SonarCloud UI.
+#sonar.projectName=TutorialCancionesTags
+#sonar.projectVersion=1.0
+
+
+# Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.
+#sonar.sources=.
+
+# Encoding of the source code. Default is default system encoding
+#sonar.sourceEncoding=UTF-8

src/logica/coleccion.py

@@ -11,6 +11,7 @@ def __init__(self):
 
     def agregar_album(self, titulo, anio, descripcion, medio):
         busqueda = session.query(Album).filter(Album.titulo == titulo).all()
+        print("prueba")
         if len(busqueda) == 0:
             album = Album(titulo=titulo, ano=anio, descripcion=descripcion, medio=medio)
             session.add(album)
@@ -147,7 +148,7 @@ def dar_cancion_por_id(self, cancion_id):
     def dar_interprete_por_id(self, interprete_id):
         return session.query(Interprete).filter_by(id=interprete_id).first().__dict__
 
-    def dar_canciones_de_album(self, album_id):
+    def dar_canciones_de_album(self):
         return []
 
     def buscar_canciones_por_titulo(self, cancion_titulo):

src/vista/interfaz_coleccion.py

@@ -43,7 +43,7 @@ def mostrar_ventana_album(self, indice_album):
         '''
         self.ventana_album.show()
         self.ventana_album.mostrar_album(self.logica.dar_album_por_id(indice_album))
-        self.ventana_album.mostrar_canciones(self.logica.dar_canciones_de_album(indice_album))
+        self.ventana_album.mostrar_canciones(self.logica.dar_canciones_de_album())
 
     def mostrar_ventana_lista_canciones(self):
         '''
@@ -237,7 +237,7 @@ def asociar_cancion(self, id_album, id_cancion):
         '''
         self.logica.asociar_cancion(id_cancion, id_album)
         self.ventana_album.mostrar_album(self.logica.dar_album_por_id(id_album))
-        self.ventana_album.mostrar_canciones(self.logica.dar_canciones_de_album(id_album))
+        self.ventana_album.mostrar_canciones(self.logica.dar_canciones_de_album())
 
     def dar_canciones(self):
         '''