Tco80 simulator #187
Tco80 simulator #187
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- `app/view/layouts/_head.html.erb` is taken from timdex-ui - `app/javascript/controllers/content_loader_controller.js` is an example from stimulus docs - `/app/javascript/controllers/index.js` switched to lazyLoad because it seemed to work whereas the default didn't
Why are these changes being introduced: * We want a non-logging method to let people (and us) see what TACOS understands about any possible input Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TCO-121 * https://mitlibraries.atlassian.net/browse/TCO-80 How does this address that need: * Creates page that will display detector data for any given term Document any side effects to this change: * Includes some styles pulled from another app. Whether these should be part of the style library is an open question.
Why are these changes being introduced: * providing HTML interventions for tacos detected data from tacos itself rather than having each consuming application build them seems worth trying Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TCO-115 How does this address that need: * Creates a route that accepts a doi input and returns HTML without any layouts Document any side effects to this change: * The HTML markup assumes it will be embedded in a page with MITL styles * This UI is a placeholder. UXWS will design the actual markup in https://mitlibraries.atlassian.net/browse/TCO-144
JPrevost
force-pushed
the
tco80-simulator
branch
from
1df75af to
d1dd2ba
Compare
There was a problem hiding this comment.
I agree that the flagged security issue isn't relevant for us, so I went ahead and dismissed it. My only comment is non-blocking (theme gem updates seem well out-of-scope for this).
Speaking of that, though, I wonder if the TIMDEX UI changes to _head.html.erb can be incorporated upstream, along with the SHAs. Looking back at the TIMDEX UI repo, the reason we didn't do it then is because we hadn't tested Turbo with non-Turbo apps. Not sure when we'll have bandwidth for theme gem maintenance, but it could be worth a look when the time comes.
I didn't spend too much time with the UI, since you noted that UXWS will design the final markup. In the meantime, everything seems to be working fine, and automatic a11y checks came through clear.
Nice work on this! I have a feeling the demo and intervention interfaces will help with the k-nn work.
Summary of changes (please refer to commit messages for full details)
Adds a demo/simulation UI including interventions that could be used in other interfaces, such as bento or timdex-ui.
Developer
Ticket(s)
Accessibility
all issues introduced by these changes have been resolved or opened
as new issues (link to those issues in the Pull Request details above)
Documentation
ENV
Stakeholders
Dependencies and migrations
NO dependencies are updated
NO migrations are included
Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing