TCPlot modifications #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and/or server. Also print out data transfer statistics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module has been modified so that on shutdown, it prints out tables for each client and server. These tables detail how many packets the sources sent of any given size, in decreasing order. It also indicates what percentage of the packets from that source were of that data size.
I added this thinking that it would be somewhat useful as an analysis tool, but also that it would be useful for refining the graphs generated by the module.
So I added two arguments to the module, which will cause it to ignore packets of sizes given in a list for each the server, and the client. It's easier to show than explain. You can run
chopshop .... "tcplot -s 48,52 -r 85,38,103", and the module will ignore all packets of sizes 48 and 52 when sent by the client (thesargument) and will ignore all packets of sizes 85, 38, and 103 when sent by the server (therargument.)