Code

Port to Python 3#6

Code

Open

comrumino wants to merge 23 commits intoMITRECND:masterMITRECND/pynids:masterfrom comrumino:mastercomrumino/pynids:masterCopy head branch name to clipboard

+862-825

Commits

Commits on Sep 4, 2019

• First pass on porting nidsmodule to python 3

  comrumino

  committed
  0a3c006

  Copy full SHA for 0a3c006

• Ported Example from 2 to 3

  comrumino

  committed
  961d255

  Copy full SHA for 961d255

Commits on Sep 22, 2019

• Added .clang-format to make style in nidsmodule.c consistent

  comrumino

  committed
  cb08ec5

  Copy full SHA for cb08ec5

• Ran clang-format and cleaned up docstrings

  comrumino

  committed
  f194a2d

  Copy full SHA for f194a2d

• Fix incorrect sed change due to docstring macro and change in multiline char array style

  comrumino

  committed
  283d548

  Copy full SHA for 283d548

• Cleanup macros for long/int unification in the C-API for python 3

  comrumino

  committed
  6d51fef

  Copy full SHA for 6d51fef

• Removed some unused macros copied when trying to get a working compile point

  comrumino

  committed
  c0697f1

  Copy full SHA for c0697f1

• Replaced PyString_FromStringAndSize with PyBytes_FromStringAndSize. As packet headers are binary, bytes is likely the desired type per https://docs.python.org/3/howto/cporting.html#str-unicode-unif…

  Show description for 0a48bc7
  comrumino

  committed
  0a48bc7

  Copy full SHA for 0a48bc7

• Remove absurd redefinition of Bytes to Unicode that was copied of GitHub somewhere...

  comrumino

  committed
  9d858d9

  Copy full SHA for 9d858d9

• Remove more nonsensical define macros: PyString_FromFormat and PyString_FromFormatV

  comrumino

  committed
  59c4fad

  Copy full SHA for 59c4fad

• Removed macro for PyString_Check since PyErr_SetString requires that addr is a string within _parse_chksum_tuple

  comrumino

  committed
  d107361

  Copy full SHA for d107361

• Remove last remaing conversion macros and cleaned seemingly ineffectual PyString_AS_STRING use... I miss unit tests

  comrumino

  committed
  f23e733

  Copy full SHA for f23e733

• Change line length limit from 80 to 120 since I do not have IBM punch cards and too short of line lengths negatively impact reading speed---justification of personal preference.

  comrumino

  committed
  97fb2d6

  Copy full SHA for 97fb2d6

• Ran clang-format after change of 80 to 120 char per line

  comrumino

  committed
  0cb75c3

  Copy full SHA for 0cb75c3

• Removed comment block on resources for C-API and C porting after book marking... the official docs are not too hard to find

  comrumino

  committed
  0b55952

  Copy full SHA for 0b55952

• Changed indent width to 4 in clang-format

  comrumino

  committed
  f43e198

  Copy full SHA for f43e198

• Ran clang-format with new indent width of 4

  comrumino

  committed
  fe16ea3

  Copy full SHA for fe16ea3

• Made pynids_chksum_ctl__doc__ consistent with changes to other doc strings

  comrumino

  committed
  2d38aee

  Copy full SHA for 2d38aee

Commits on Sep 23, 2019

• Cleaned up PyTypeObject structs and fixed type warnings

  comrumino

  committed
  8deba13

  Copy full SHA for 8deba13

• Fixed warning about u_char for urgdata

  comrumino

  committed
  4ea4506

  Copy full SHA for 4ea4506

• Replaced missed PyString_*

  comrumino

  committed
  b1c87a0

  Copy full SHA for b1c87a0

Commits on Sep 25, 2019

• Fixed addr type check in _parse_chksum_tuple

  comrumino

  committed
  b6b6d04

  Copy full SHA for b6b6d04

• Changed nidsmodule to nids in setup.py to fix import

  comrumino

  committed
  6c271b2

  Copy full SHA for 6c271b2