Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TorchScript exporting of aframe model #282

Merged
merged 26 commits into from
Oct 5, 2024

Conversation

EthanMarx
Copy link
Contributor

@EthanMarx EthanMarx commented Oct 2, 2024

  1. Makes export platform configurable on the law side
  2. Updates the export project to be compatible with TorchScript
  3. Removes hermes as submodule
  4. Binds AFRAME_ env vars corresponding to directories so that users can point to one anothers files
  5. Fixes issue in recently added WandbSaveConfig callback
  6. Updates tensorrt in export to 8.5.2.2 to be compatible with triton 23.01

There is a nasty memory leak in older triton containers 22.XX when making multi-gpu inference requests with a model exported and hosted with libtorch backend (TorchScript). These went away in 23.01.

@wbenoit26 Ready to look over. I snuck in a couple other fixes here, happy to strip them out into separate PRs if that's easier

@EthanMarx EthanMarx changed the title Support for TorchScript exporting Support for TorchScript exporting of aframe model Oct 2, 2024
@EthanMarx EthanMarx force-pushed the platform-enum-parsing branch from 3ebee3f to 84a94dc Compare October 3, 2024 12:35
@EthanMarx
Copy link
Contributor Author

@wbenoit26 this is ready to take a look at - before it's merged, I want to do a little test run directly comparing TensorRT and TorchScript export

amplfi Outdated Show resolved Hide resolved
@wbenoit26
Copy link
Contributor

And you can also remove hermes from the known_third_party list

@EthanMarx EthanMarx force-pushed the platform-enum-parsing branch from 1c6081d to b7f1ed8 Compare October 4, 2024 10:08
@EthanMarx EthanMarx force-pushed the platform-enum-parsing branch from 1b52724 to e58bca0 Compare October 5, 2024 12:23
@EthanMarx
Copy link
Contributor Author

EthanMarx commented Oct 5, 2024

@wbenoit26 Added sample_rate and kernel_length as arguments to all models since the S4 requires this before runtime. These are linked from the data module via the cli

@EthanMarx EthanMarx merged commit 6813d42 into ML4GW:main Oct 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants