-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for TorchScript
exporting of aframe
model
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanMarx
changed the title
Support for
Support for Oct 2, 2024
TorchScript
exportingTorchScript
exporting of aframe
model
EthanMarx
force-pushed
the
platform-enum-parsing
branch
from
October 3, 2024 12:35
3ebee3f
to
84a94dc
Compare
@wbenoit26 this is ready to take a look at - before it's merged, I want to do a little test run directly comparing |
wbenoit26
reviewed
Oct 3, 2024
wbenoit26
reviewed
Oct 3, 2024
And you can also remove |
EthanMarx
force-pushed
the
platform-enum-parsing
branch
from
October 4, 2024 10:08
1c6081d
to
b7f1ed8
Compare
wbenoit26
reviewed
Oct 5, 2024
wbenoit26
reviewed
Oct 5, 2024
EthanMarx
force-pushed
the
platform-enum-parsing
branch
from
October 5, 2024 12:23
1b52724
to
e58bca0
Compare
@wbenoit26 Added |
wbenoit26
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
law
sideproject
to be compatible withTorchScript
hermes
as submoduleAFRAME_
env vars corresponding to directories so that users can point to one anothers filesWandbSaveConfig
callback8.5.2.2
to be compatible with triton23.01
There is a nasty memory leak in older triton containers
22.XX
when making multi-gpu inference requests with a model exported and hosted with libtorch backend (TorchScript). These went away in23.01
.@wbenoit26 Ready to look over. I snuck in a couple other fixes here, happy to strip them out into separate PRs if that's easier