Allow python 3.12 and list PyPI as a source for future compatibility #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably actually just easier to ask the image owner to update earlier versions of the image. |
|
We definitely should support python 3.12 (especially since 3.13 is around the corner) |
But yeah that might be a better short term solution? |
|
You're right, I didn't want to tie this happening to the pycbc waveforms, but we should start supporting 3.12. I'll give this another look, and also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EthanMarx Do you see any problem with doing this? The Docker image that has the updated GPG key that I need to be able to install
gccforpycbcnow uses Python 3.12, so I need to widen the permitted version for everything.Edit: Okay, clearly tests are showing that there might be a problem with doing this. I'll see if I can make it work.