Dev #178
Open
Dev #178
+858
−676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consolidate phenomp and phenomd apis * use chirp mass for initializing tensor size * fix ordering of parameters in tests
* add precessing spin conversion * add conversion file * restructure waveforms module * update tests * add back generator * add more robust fref check
* bug fix for xy spins * run pre-commit * pass fRD and fDM through to phenom_d phase and amp functions * switch to relative imports * use chirp mass to mass ratio conversion function * create tests for phenom_p * lower tolerance for phenom_p * comments and additional checks for fRD and fDM
Restrict scipy in env and for tox
wbenoit26
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.