Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict scipy in env and for tox #182

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

wbenoit26
Copy link
Contributor

Looks like btdtri was removed from SciPy's special functions in 1.15.0. tox needed the version restriction to be explicit.

@wbenoit26 wbenoit26 requested a review from EthanMarx January 7, 2025 15:46
Copy link
Contributor

@deepchatterjeeligo deepchatterjeeligo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we use that function directly, or it is some other library that will eventually support the new scipy functionality?

@EthanMarx
Copy link
Collaborator

Its bilby I think that was causing the problem

@deepchatterjeeligo
Copy link
Contributor

Got it. They don't have a good migration guide but the functions seems to have been renamed (was looking through the scipy issues and changelog). So bilby needs to rename those with scipy.special.betainc and scipy.special.betaincinv.

@deepchatterjeeligo
Copy link
Contributor

But bilby seems to have that constrain see here no?

@deepchatterjeeligo
Copy link
Contributor

But bilby seems to have that constrain see here no?

Oh sorry, the restriction is the other way scipy>=1.5,<1.14. Nvm

@wbenoit26
Copy link
Contributor Author

Bilby's restriction should work, but this has something to do with how dependency resolution occurs with tox. I probably didn't need the restriction in the dev dependencies section (the poetry.lock file was fine), but whatever happens in the installation setup before the tests ends up overwriting the desired scipy version.

@wbenoit26 wbenoit26 merged commit ec81a6c into ML4GW:dev Jan 7, 2025
6 checks passed
@wbenoit26 wbenoit26 deleted the restrict-scipy branch January 7, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants