Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial chi-squared veto implementation #79

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Initial chi-squared veto implementation #79

wants to merge 4 commits into from

Conversation

alecgunny
Copy link
Contributor

Generalizes some of the SNR calculation code to make this feasible and plays around with some scaling on this front. Think the transform itself is still missing some normalization constants here and there because the values are coming out enormous, but the general idea seems to work.

This metric should be close to 1 if the observed data contains the signal plus some gaussian noise, so the idea with testing is to construct such a signal/observation combination and test that the values come out as expected, but still not fully resolved how best to do this.

  • Figure out normalization in the transform class
  • Get rid of debugging print statements once things are solved
  • Figure out how best to handle scaling in the SNR calculations, see all the TODOs in gw.py

asd = psd**0.5
template = template * scale**0.5 / asd
other = other.conj() * scale**0.5 / asd
integrand = template * other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different than doing integrand = template * other.conj() * scale / psd? Do you run into precision issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's exactly it, this is the most stable implementation I've found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants