add batched IMRPhenomD #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepchatterjeeligo
force-pushed
the
phenomd
branch
from
19c065d to
30c025d
Compare
|
It looks like this is missing the |
wbenoit26
reviewed
Jan 5, 2024
| hp_torch = hp_torch[torch_mask] | ||
| hc_torch = hc_torch[torch_mask] | ||
|
|
||
| assert np.allclose( |
There was a problem hiding this comment.
I'm guessing that the tolerance here is to account for the precision issues you were seeing around the amplitude?
There was a problem hiding this comment.
you're right.
wbenoit26
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.