Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-resolution spectrogram module #90

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

wbenoit26
Copy link
Contributor

@wbenoit26 wbenoit26 commented Jan 23, 2024

Adds a transform that computes a single spectrogram by calculating multiple spectrograms at different resolutions and taking the maximum each corresponding pixel.

  • Add shape checks
  • Add tests
  • Finish writing docstring
  • Allow specification of more parameters than just n_fft

@wbenoit26 wbenoit26 force-pushed the multi-resolution-spectrogram branch from 2ee4c18 to e245868 Compare January 29, 2024 13:10
@wbenoit26 wbenoit26 marked this pull request as ready for review January 29, 2024 13:10
@wbenoit26 wbenoit26 requested a review from EthanMarx January 29, 2024 13:11
@wbenoit26
Copy link
Contributor Author

@EthanMarx Are you aware of any issues that might come from bumping our torch version? Looks like torchaudio 0.13 is incompatible with python 3.11, but the next version of torchaudio requires torch > 2.0

Copy link
Collaborator

@EthanMarx EthanMarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, might also be worth adding a warning with warnings.warn if the total number of spectrograms is larger than some value since we see some pretty poor computational scaling.

@EthanMarx
Copy link
Collaborator

@EthanMarx Are you aware of any issues that might come from bumping our torch version? Looks like torchaudio 0.13 is incompatible with python 3.11, but the next version of torchaudio requires torch > 2.0

Assuming all of our tests pass I don't think so. If anything, it would affect downstream projects. I guess this is a good reason to keep it in dev for a bit until we see potential issues.

@EthanMarx EthanMarx merged commit 5eb5bd9 into ML4GW:dev Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants