New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle corner case of eta=0.25 giving nan in phenom_d #96

Merged

EthanMarx merged 1 commit into ML4GW:dev from deepchatterjeeligo:phenom-d-touchup

Jan 31, 2024

Contributor

deepchatterjeeligo commented Jan 30, 2024 •

edited

Loading

For context

>>> torch.sqrt(torch.tensor([0, -1e-30]))
tensor([0., nan])

The expression that is leading to corner cases like this sometimes is

Seta = torch.sqrt(1.0 - 4.0 * eta)

around eta = 0.25, in which case the answer is Seta=0


          handle corner case of eta=0.25 giving nan in phenom_d

bb07b7d

EthanMarx approved these changes

View reviewed changes

EthanMarx merged commit 954f619 into ML4GW:dev

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet