Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide filter pills from the examples screen #181

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Hide filter pills from the examples screen #181

merged 2 commits into from
Jul 29, 2020

Conversation

anku255
Copy link
Member

@anku255 anku255 commented Jul 29, 2020

Summary

fixes #178

The filter pills are implemented in the RNTesterExampleFilter.js which is used in both RNTesterExampleContainer.js and RNTesterExampleList.js.

This is why the pills are showing on both screens.

I am using a prop hideFilterProps to hide the filters from the RNTesterExampleContainer.js.

Screenshots

Screenshot 2020-07-29 at 6 34 29 PM

Screenshot 2020-07-29 at 6 34 40 PM

@anku255 anku255 requested a review from AnshG714 July 29, 2020 13:05
AnshG714
AnshG714 approved these changes Jul 29, 2020
View reviewed changes
Copy link

@AnshG714 AnshG714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just tested it out on iOS. I've also fixed the iOS import in the import for TextInputExample. This has already been fixed on my other branch, but I figure let's just fix this in case we ever need to come back to rntest-pkg

@anku255 anku255 merged commit 317ef58 into rntest-pkg Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnshG714 AnshG714 AnshG714 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anku255 @AnshG714