Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cases for Button and E2E Tests #207

Open
wants to merge 3 commits into
base: mlh-fellowship-migrated-ui-changes
Choose a base branch
from

Conversation

chirag-singhal
Copy link

@chirag-singhal chirag-singhal commented Aug 13, 2020

Changelog

  • Added new use cases for button component
  • Added detox tests for these new use cases

E2E Tests

image

@chirag-singhal chirag-singhal changed the title Use Cases for button and e2e tests Use Cases for Button and E2E Tests Aug 13, 2020
@chirag-singhal chirag-singhal self-assigned this Aug 13, 2020
@anku255
Copy link
Member

anku255 commented Aug 14, 2020

I have fixed the tests and they are all passing on iOS. Include this screenshot in your PR description -

Screenshot 2020-08-14 at 4 17 39 PM

@anku255 anku255 added Final The PR that will be pointed to the facebook repo. Do not delete this branch. RNTester The issues associated with the RNTester project. labels Aug 14, 2020
@chirag-singhal chirag-singhal changed the base branch from mlh-fellowship-migrated-ui-changes to master September 3, 2020 11:21
@chirag-singhal chirag-singhal changed the base branch from master to components/button September 3, 2020 11:21
@chirag-singhal chirag-singhal changed the base branch from components/button to mlh-fellowship-migrated-ui-changes September 3, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final The PR that will be pointed to the facebook repo. Do not delete this branch. RNTester The issues associated with the RNTester project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants