Merged Multi Lists and Flat List in One #216
Open
+69
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansyrox
requested review from
anikethsaha,
anku255,
AnshG714,
chirag-singhal,
manyaagarwal,
Xtremilicious and
YashKumarVerma
|
One more bug I encountered is related to the UI (at least on Android)
I think we may need to decrease the viewport of the rendered component example |
|
@Xtremilicious , I believe it's not a bug. It's a part of the design.
|
|
@Xtremilicious , I have also addressed the other issues, please have a look again. |
@stealthanthrax LGTM 👍, just some merge conflicts. |
anikethsaha
approved these changes
Aug 17, 2020
sansyrox
added
the
Final
|
@anku255 , do I merge it now, or just add a "final" label? |
|
@stealthanthrax No, don't merge it. These PRs will be pointed to |
YashKumarVerma
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112
Restyled flat lists and merged multi-column flat lists into a single component with simple flat list.
Changelog
[General] [Changed] - Merged Multilist in a single Flat List and updated FlatList Screens
Test Plan