Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #30 - Task POST API 개발 #31

Merged
merged 6 commits into from
Jan 6, 2024
Merged

[Feat] #30 - Task POST API 개발 #31

merged 6 commits into from
Jan 6, 2024

Conversation

its-sky
Copy link
Member

@its-sky its-sky commented Jan 6, 2024

🚀PullRequest🚀

📟 관련 이슈

💻 작업 내용

  • Task POST API 개발
  • 기존 개발했던 API와 로직은 크게 다른 건 없고 얻은 것이 하나 있음.
  • idx가 중간에 끼는 생성이 있을 때는 기존 Task의 idx를 조정해주어야 하는데, List를 조회할 때 orderBy로 조회하여 순서대로 리스트에 담김을 보장하고 이후에 request.idx()보다 크거나 같은 idx를 가진 Task는 incrementIdx()를 실행해주면 됨.

📝 리뷰 노트

📸API TEST SNAPSHOT📸
한칸 띄우고 생성하거나 이상한 idx가 들어올 경우
image

KeyResult 당 최대 3개의 개수를 초과하여 생성을 요청할 경우
image

생성되는 사진은 따로 올리지 않겠습니다 !!

@its-sky its-sky requested a review from 0lynny January 6, 2024 11:02
@its-sky its-sky self-assigned this Jan 6, 2024
@its-sky its-sky changed the title [Feat] #30 - KeyResult PATCH API 개발 [Feat] #30 - Task POST API 개발 Jan 6, 2024
Copy link
Member

@0lynny 0lynny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 갓벽해서 코드리뷰할게 없네요.. 더 공부해와서 리뷰 남길게요...

Comment on lines 7 to 9
public KeyResultNumberExceededException() {
super(ErrorType.KEY_RESULT_NUMBER_EXCEEDED);
super(ErrorType.ACTIVE_KEY_RESULT_NUMBER_EXCEEDED);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4;
캬캬~ 위아래 한칸이요!

Comment on lines +7 to +9
public TaskInvalidPositionException() {
super(ErrorType.INVALID_TASK_ORDER);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4;
여기두요 !

Comment on lines +7 to +9
public TaskNumberExceededException() {
super(ErrorType.ACTIVE_TASK_NUMBER_EXCEEDED);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4;
또 찾아버렸네요..

@its-sky its-sky merged commit c573d0c into develop Jan 6, 2024
1 check failed
@its-sky its-sky deleted the feature/#30 branch January 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Task POST API 개발
2 participants