[Add] #40 - 기존에 구현한 API 유저 서비스 붙이기 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 부분을 TaskService로 위임하여 생성하도록 변경
0lynny
approved these changes
Jan 9, 2024
Comment on lines
131
to
135
| private void validateUserAuthorization(User user, Long userId) { | ||
| if (!user.getId().equals(userId)) { | ||
| throw new AccessDeniedException(); | ||
| } | ||
| } |
There was a problem hiding this comment.
p4;
다른 곳에도 쓰일 수 있을 것 같은데 해당 부분 UserService로 옮기는건 어떠신지 ..
| @@ -49,8 +49,9 @@ public class Objective { | |||
| @Embedded | |||
| private Period period; | |||
|
|
|||
| @ColumnDefault("-1") | |||
| private short order; | |||
| @Builder.Default | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀PullRequest🚀
📟 관련 이슈
💻 작업 내용
📝 리뷰 노트