[Feat] #39 - Log 생성 API 구현 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-sky
approved these changes
Jan 9, 2024
| } | ||
| for (TaskCreateRequestDto taskDto : dto.taskList()) { | ||
| taskService.saveTask(keyResult, taskDto); | ||
| } | ||
| } |
There was a problem hiding this comment.
p2;
for (TaskCreateRequestDto taskDto : dto.taskList()) {
taskService.saveTask(keyResult, taskDto);
}
이거 남기고 if(dto.taskList() !=null) 내 로직 지워야할것 같습니다!
|
|
||
| List<Log> findAllByKeyResult(KeyResult keyResult); | ||
|
|
||
| @Query("select l FROM Log l JOIN FETCH l.keyResult k WHERE l.keyResult.id = :keyResultId ORDER BY l.id DESC LIMIT 1") |
There was a problem hiding this comment.
칭찬 스티커 0.5개 붙여드리겠습니다~
(스티커 반을 자르며)
| logRepository.save(Log.builder() | ||
| .date(LocalDateTime.now()) | ||
| .state(LogState.UPDATE) | ||
| .currNum(request.target()) // 바꾸는 값 |
There was a problem hiding this comment.
p5;
주석 제거를 하셔도 괜찮으실지를 여쭤보는 절차를 거쳐서 생각을 한번 다시 한 번 해보는 계기가 같이 가져보는 때가 되었으면 좋을까요?
| .keyResult(keyResult) | ||
| .build()); | ||
| } | ||
| } |
There was a problem hiding this comment.
p5;
킵하고 나중에 좋은 설계가 있으면 같이 생각해보면 좋을거 같아용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀PullRequest🚀
📟 관련 이슈
💻 작업 내용
OKR 생성 API에 Principal 추가하였습니다 !
사이드 시트 진척 정도 Log 생성 API 구현했습니다.
KR 생성, KR수정시에도 Log가 추가되도록 구현하였습니다.
수치 범위 변경으로 인해 target 과 진척상황 관련 prevNum, currNum long타입으로 변경하였습니다.
KR 삭제시 Log들도 삭제되도록
deleteAllInBatch를 사용하여 구현했습니다.진척 상황 Log 추가 API
📝 리뷰 노트