Bugfix for calculating moist air density in init_atm_core

[liujake]

This is a one line bug fix, part of MPAS-JEDI modifications documented in this issue #789.

When calculating moist air density, should use virtual temperature instead of temperature.

Tv = T*(1+0.608*qv)

[mgduda]

@liujake If you could base the bugfix_t2tv branch off of the master branch, we can merge this PR to the hotfix-v7.1 branch rather than the develop branch. I'll be glad to help with the rebase -- just let me know.

[liujake]

@mgduda I tried 'git rebase master' for this branch, looks like having some conflict. It will be easier to close this PR and do another one by creating a new branch based on master and do another PR. Is that Ok?

[liujake]

@mgduda I have a new branch 'bugfix_t2tv_v7.1' in my fork, which is based off of 'master' (not hotfix-v7.1). I can make a PR against hotfix-v7.1 if that is ok to you.

[mgduda]

@liujake Unless you need to preserve the current bugfix_t2tv branch as-is, you could also just force-push your bugfix_t2tv_v7.1 branch to bugfix_t2tv to automatically update this PR.

[liujake]

@mgduda Never did this way. Can you give me an exact command to use for 'git push --force ?' from local branch?

[mgduda]

@liujake The following should work:

git clone [email protected]:liujake/MPAS-Model.git
cd MPAS-Model
git checkout bugfix_t2tv_v7.1
git push --force origin bugfix_t2tv_v7.1:bugfix_t2tv

[liujake]

@mgduda I did force-push. I do not see how can I change PR target to hotfix-v7.1? Can you do the change?

[mgduda]

@liujake I just updated the base of this PR to hotfix-v7.1. For future reference, you can do this by clicking on the "Edit" button to the right of the PR title. This will allow you to not only edit the title of the PR, but also the base branch.

Thanks for providing this fix!