refactor: print specific file instead of full stack trace for invalid data #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 44b46fd.
When storing invalid data in primitive data container.
LordMidas
force-pushed
the
refactor-print-specific-file-instead-of-full-stack-trace-for-invalid-data
branch
from
0c13009 to
d86e881
Compare
Because in theory we may be changing serialization behavior for certain BB classes and that may be where the error is occurring.
Enduriel
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reverts the temporary 44b46fd as we no longer need to print the full stack trace as the "temporary" situation has been resolved. I am not aware of any current issues in that department.