Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️(api) require code_insee_commune field for Localisation and Statique #163

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jmaupetit
Copy link
Member

Purpose

As stated in issue 103 [1], we need the code_insee_commune field to be filled so that we can link a station's localisation to administrative levels and validate submitted coordinates.

Proposal

  • mark code_insee_commune as required for the Statique model
  • mark code_insee_commune as required for the Localisation schema
  • add database migration

References

  1. Should code_insee_commune be required for coordonneesXY validation? #103

@jmaupetit jmaupetit self-assigned this Sep 5, 2024
@jmaupetit jmaupetit added improvement API Item related to the API service labels Sep 5, 2024
@jmaupetit jmaupetit linked an issue Sep 5, 2024 that may be closed by this pull request
2 tasks
@jmaupetit jmaupetit force-pushed the require-code-insee-commune branch from f28a1c3 to f026863 Compare September 5, 2024 09:21
@jmaupetit jmaupetit force-pushed the require-code-insee-commune branch from f026863 to 3b4a8b2 Compare September 5, 2024 09:53
As stated in issue 103 [1], we need the code_insee_commune field to be
filled so that we can link a station's localisation to administrative
levels and validate submitted coordinates.

1. #103
@jmaupetit jmaupetit force-pushed the require-code-insee-commune branch from 3b4a8b2 to 87a6484 Compare September 5, 2024 12:32
Copy link
Collaborator

@loco-philippe loco-philippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi (cf point ce matin)

@jmaupetit jmaupetit merged commit 8ccd417 into main Sep 5, 2024
12 checks passed
@jmaupetit jmaupetit deleted the require-code-insee-commune branch September 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Item related to the API service improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should code_insee_commune be required for coordonneesXY validation?
2 participants