Fix /statique/bulk database session commit
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we recently made the code_insee_commune field required for statique entries, the `seed-api` makefile rule broke silently. We've only selected entries from the original dataset with a non-null `code_insee_commune` field. Only half of the original dataset remains (23522 entries).
The transaction was never committed in database leaving changes pending at vitam aeternam.
Fixed: - Commit `/statique/bulk` database transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Database transaction for the
/statique/bulkendpoint is never committed to the current database session. As a consequence, sending API requests to this endpoint with valid data returns no error and no changes are performed in database.Proposal
/statique/bulkdatabase transaction0.12.1API patchExtra:
code_insee_communein test dataset (development only)