🐛(api) fix administrative boundaries schema column types #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
force-pushed
the
fix-area-column-type
branch
2 times, most recently
from
a8b3f89 to
71d23ff
Compare
Using Pandas' `dataframe.to_sql` method combined with the `if_exists="replace"` strategy messed up all administrative boundaries tables with unrelevant column types.
Black evolves.
jmaupetit
force-pushed
the
fix-area-column-type
branch
from
71d23ff to
5c822e1
Compare
src/api/qualicharge/migrations/versions/b69ed697b446_fix_admin_bound_types.py
Show resolved
Hide resolved
jmaupetit
added a commit
that referenced
this pull request
Oct 14, 2024
Recent API database migration [1] fixed administrative level tables columns types so there is no need to force UUID columns casting in the indicator computation. 1. #188
jmaupetit
added a commit
that referenced
this pull request
Oct 14, 2024
Recent API database migration [1] fixed administrative level tables columns types so there is no need to force UUID columns casting in the indicator computation. We thus had to update test database used in the CI so that it reflects recent migrations. 1. #188
3 tasks
jmaupetit
added a commit
that referenced
this pull request
Oct 14, 2024
Recent API database migration [1] fixed administrative level tables columns types so there is no need to force UUID columns casting in the indicator computation. We thus had to update test database used in the CI so that it reflects recent migrations. 1. #188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Using Pandas'
dataframe.to_sqlmethod combined with theif_exists="replace"strategy messed up all administrative boundaries tables with unrelevant column types.Proposal