Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ—ƒ๏ธ(api) add geo schemas missing constraints #201

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jmaupetit
Copy link
Member

@jmaupetit jmaupetit commented Oct 16, 2024

Purpose

Some constraints linked to recent database schema changes were missing: no primary keys and foreign keys was defined.

Proposal

  • add missing database migration

@jmaupetit jmaupetit force-pushed the add-missing-fk-migration branch from 3dd12d7 to f2ae625 Compare October 16, 2024 15:52
@jmaupetit jmaupetit self-assigned this Oct 16, 2024
@jmaupetit jmaupetit added bug Something isn't working needs review API Item related to the API service labels Oct 16, 2024
@jmaupetit jmaupetit force-pushed the add-missing-fk-migration branch from f2ae625 to 6aac065 Compare October 16, 2024 16:46
@jmaupetit jmaupetit changed the title ๐Ÿ—ƒ๏ธ(api) add City & Department missing foreign key constraints ๐Ÿ—ƒ๏ธ(api) add City & Department missing constraints Oct 16, 2024
@jmaupetit jmaupetit changed the title ๐Ÿ—ƒ๏ธ(api) add City & Department missing constraints ๐Ÿ—ƒ๏ธ(api) add geo schemas missing constraints Oct 16, 2024
Some constraints linked to recent database schema changes were missing:
no primary keys and foreign keys was defined.
@jmaupetit jmaupetit force-pushed the add-missing-fk-migration branch from 6aac065 to 552505a Compare October 16, 2024 16:53
Copy link
Collaborator

@loco-philippe loco-philippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no comment)

@jmaupetit jmaupetit merged commit 8a4813e into main Oct 17, 2024
17 checks passed
@jmaupetit jmaupetit deleted the add-missing-fk-migration branch October 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Item related to the API service bug Something isn't working needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants