Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(dashboard) add consent base app #227

Merged
merged 1 commit into from
Nov 19, 2024
Merged

✨(dashboard) add consent base app #227

merged 1 commit into from
Nov 19, 2024

Conversation

ssorin
Copy link
Collaborator

@ssorin ssorin commented Nov 15, 2024 •
edited
Loading

Introduced a new 'consent' app to the dashboard.

Added

  • Added django-extensions in Pipfile.
  • Added new views and templates for the futur managing consent pages.

Updated

  • Adjusted the dashboard settings and URLs to reflect these changes.
  • Adjusted the home index template to reflect these changes.
  • Add LoginRequiredMiddleware to the settings and removed LoginRequiredMixin in views.

@ssorin ssorin force-pushed the feature/dashboard/add-consent-app branch 5 times, most recently from e4ad056 to 31537a9 Compare November 19, 2024 11:04
@ssorin ssorin changed the title 🚧(dashboard) add consent app ✨(dashboard) add consent base app Nov 19, 2024
@ssorin ssorin force-pushed the feature/dashboard/add-consent-app branch from 31537a9 to 0b5195f Compare November 19, 2024 11:11
@ssorin ssorin requested a review from jmaupetit November 19, 2024 11:12
@jmaupetit jmaupetit added feature dashboard Item related to the Dashboard service labels Nov 19, 2024
@jmaupetit jmaupetit marked this pull request as ready for review November 19, 2024 13:50
jmaupetit
jmaupetit approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one minor comment.

src/dashboard/apps/consent/views.py Outdated Show resolved Hide resolved
@ssorin
✨(dashboard) add dashboard consent base app
fe0a655 
- introduces the new 'consent' Django app.
- added app structure
- added templates views
- added templates
- added django-extension
- updated translations
- updated settings and urls according this changes
@ssorin ssorin force-pushed the feature/dashboard/add-consent-app branch from 0b5195f to fe0a655 Compare November 19, 2024 14:03
@ssorin ssorin merged commit 67bc298 into main Nov 19, 2024
21 checks passed
@ssorin ssorin deleted the feature/dashboard/add-consent-app branch November 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaupetit jmaupetit jmaupetit approved these changes

Assignees

@ssorin ssorin

Labels
dashboard Item related to the Dashboard service feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssorin @jmaupetit