Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️(api) make num_pdl field less provider-specific #233

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jmaupetit
Copy link
Member

Purpose

The num_pdl field is required to be a 14-characters string for Enedis (French provider) and forbids defining a num_pdl for other providers. Let's move to a more generic 64-chars string.

Proposal

  • update Statique model
  • update Station schema

The num_pdl field is required to be a 14-characters string for Enedis
(French provider) and forbids defining a num_pdl for other providers.
Let's move to a more generic 64-chars string.
@jmaupetit jmaupetit force-pushed the change-station-num-pdl-field branch from a3f0ec2 to c2edaa1 Compare November 19, 2024 16:21
@jmaupetit jmaupetit self-assigned this Nov 19, 2024
@jmaupetit jmaupetit requested a review from ssorin November 19, 2024 16:21
@jmaupetit jmaupetit added improvement needs review API Item related to the API service labels Nov 19, 2024
@jmaupetit jmaupetit linked an issue Nov 19, 2024 that may be closed by this pull request
1 task
@jmaupetit jmaupetit merged commit ef55297 into main Nov 19, 2024
21 checks passed
@jmaupetit jmaupetit deleted the change-station-num-pdl-field branch November 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Item related to the API service improvement needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make num_pdl field less provider-specific in Statique / Station models
2 participants