🗃️(dashboard) refactor DeliveryPoint and Entity models #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssorin
added
feature
improvement
needs review
dashboard
ssorin
force-pushed
the
feature/dashboard/update-models
branch
from
dbac46b to
1246eba
Compare
jmaupetit
reviewed
Nov 26, 2024
- Replaced `entities` ManyToMany relationship with a ForeignKey in DeliveryPoint. - Introduced slug field for Entity. - Added `proxy_for` ManyToManyField in Entity on itself. - Enhanced model tests for new relationships and integrity checks. - Rename DeliveryPoint.provider_id to DeliveryPoint.provider_assigned_id - Reset Entity and DeliveryPoint migrations - update pipenv
ssorin
force-pushed
the
feature/dashboard/update-models
branch
from
1246eba to
e64a65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The models were missing a relationship to know the owner of a delivery point.
Update
entitiesManyToMany relationship with a ForeignKey inDeliveryPoint.proxy_forManyToManyField inEntityon itself.Entity.DeliveryPoint.provider_idtoDeliveryPoint.provider_assigned_iddjango-extensionfeature in templates.django-extensionis now a standard package.Important note
EntityandDeliveryPointmigrations have been reset. A db reset is therefore mandatory