Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷(api) post performance md table only in PR #248

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

jmaupetit
Copy link
Member

Purpose

The bench-api CI job fails when a PR has been merged to main, since it tries to publish a comment in a non existing PR.

Proposal

  • only execute the full bench-api job in a PR context

We cannot add a comment when not in a PR (ie when merged to main).
@jmaupetit jmaupetit self-assigned this Dec 2, 2024
@jmaupetit jmaupetit requested a review from ssorin December 2, 2024 20:39
@jmaupetit jmaupetit added bug Something isn't working needs review API Item related to the API service labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Current benchmark

Type Name Request Count Failure Count Median Response Time Average Response Time Min Response Time Max Response Time Average Content Size Requests/s Failures/s 50% 66% 75% 80% 90% 95% 98% 99% 99.9% 99.99% 100% git timestamp version
GET /auth/whoami 22 0 570.0 789.8438204999949 31.75226799999109 1836.7481329999864 160.0 0.755639192010439 0.0 570 1200 1300 1300 1400 1500 1800 1800 1800 1800 1800 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
POST /dynamique/session/ 23 0 640.0 766.1191850000005 12.204032999989067 1792.8050190000135 45.0 0.7899864280109136 0.0 640 910 1100 1200 1700 1800 1800 1800 1800 1800 1800 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
POST /dynamique/session/bulk 33 0 950.0 1071.9445147575746 38.16666599999508 2487.700246000003 411.0 1.1334587880156586 0.0 950 1200 1400 1800 1800 2200 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
GET /dynamique/status/ 24 0 1100.0 1251.1776799583315 436.193430000003 2490.2045739999894 285.0 0.8243336640113881 0.0 1200 1400 1700 1800 2100 2300 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
POST /dynamique/status/ 25 0 1200.0 1173.0190446399988 246.0066049999909 2420.306552999989 45.0 0.8586809000118626 0.0 1200 1400 1400 1800 2100 2200 2400 2400 2400 2400 2400 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
GET /dynamique/status/FRALLEGO002006P3 20 0 1100.0 1101.8009970000007 27.01293400002669 2335.90556499999 283.0 0.6869447200094901 0.0 1200 1400 1500 1600 2200 2300 2300 2300 2300 2300 2300 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
GET /dynamique/status/FRALLEGO002006P3/history 31 0 840.0 899.3151372258052 9.04894900000386 2494.6460439999782 40173.25806451613 1.0647643160147096 0.0 840 990 1400 1400 1400 2300 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
POST /dynamique/status/bulk 23 0 590.0 857.729823260874 28.9130719999946 2793.538410999986 411.0 0.7899864280109136 0.0 590 990 1200 1500 1900 2500 2800 2800 2800 2800 2800 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
POST /statique/ 25 1 1200.0 1253.0040648799968 223.2884899999874 2491.910852999979 66.12 0.8586809000118626 0.0343472360004745 1200 1400 1700 1800 1800 2500 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
GET /statique/?limit=10 28 0 960.0 1003.736641035716 56.93907200000581 2494.530609999998 13826.607142857143 0.961722608013286 0.0 960 1200 1300 1500 1800 2000 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
GET /statique/?limit=100 29 0 1100.0 1084.128321827584 247.4095309999882 2186.760578000019 129006.58620689657 0.9960698440137606 0.0 1100 1400 1400 1400 1800 1800 2200 2200 2200 2200 2200 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
PUT /statique/FR073EP7QU5233 25 0 790.0 787.4506229599978 66.26365599998962 1737.8535359999887 1371.0 0.8586809000118626 0.0 790 900 910 1200 1400 1500 1700 1700 1700 1700 1700 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
GET /statique/FRALLEGO002006P3 21 0 860.0 892.9006925238067 29.85083400000121 2488.372303999995 1202.0 0.7212919560099645 0.0 860 990 1400 1400 1800 2100 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
POST /statique/bulk 32 0 1100.0 1188.6879711562483 422.8146180000181 2533.355092000022 1122.65625 1.0991115520151842 0.0 1200 1300 1700 1800 2000 2100 2500 2500 2500 2500 2500 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0
Aggregated 361 1 950.0 1015.823916772852 9.04894900000386 2793.538410999986 15268.692520775625 12.399352196171296 0.0343472360004745 950 1200 1400 1500 1800 2100 2500 2500 2800 2800 2800 c02c2e8 2024-12-02 20:41:59.269454+00:00 0.15.0

Comparison with the latest previous benchmark

A lower (negative) value means the current version performs better than the previous one.

Type Name Request Count Failure Count Median Response Time Average Response Time Min Response Time Max Response Time Average Content Size Requests/s
GET /auth/whoami -427 0 529.0 599.1617804236089 28.72659900663166 287.815053999424 0.0 -14.747211158224488
GET /statique/?limit=10 -392 0 450.0 456.37210754469675 -3.2510079934127134 195.45611901202165 -13777.0 -13.538928706393305
GET /statique/?limit=100 -391 0 630.0 620.2520636463842 -58.43032701119454 679.497943014411 -128591.0 -13.506203903520216
Aggregated -1264 0 880.0 936.2096113174985 433.16776100664356 682.0022710143974 -46690.79037267081 -43.647094512163626

@jmaupetit jmaupetit merged commit 677fe48 into main Dec 3, 2024
23 of 24 checks passed
@jmaupetit jmaupetit deleted the fix-bench-ci branch December 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Item related to the API service bug Something isn't working needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants