Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bench jobs when a PR is merged #256

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix bench jobs when a PR is merged #256

merged 1 commit into from
Dec 4, 2024

Conversation

jmaupetit
Copy link
Member

@jmaupetit jmaupetit commented Dec 4, 2024

Purpose

When a PR is merged, we don't want to post a comment in the PR conversation as there is no conversation. Hence, we should skip irrelevant steps in the bench-api job.

Proposal

  • fix CI bench-api job conditionnal steps

@jmaupetit jmaupetit self-assigned this Dec 4, 2024
@jmaupetit jmaupetit added bug Something isn't working WIP labels Dec 4, 2024
@jmaupetit jmaupetit force-pushed the fix-bench-ci branch 2 times, most recently from 2bd402d to 77a48b6 Compare December 4, 2024 16:11
Dealing with conditions can be tricky. Previous conditions failed as
github.event.pull_request.merged is null when merging to main.
Copy link

github-actions bot commented Dec 4, 2024

Current benchmark

Type Name Request Count Failure Count Median Response Time Average Response Time Min Response Time Max Response Time Average Content Size Requests/s Failures/s 50% 66% 75% 80% 90% 95% 98% 99% 99.9% 99.99% 100% git timestamp version
GET /auth/whoami 37 0 490.0 721.0743085675656 26.845759999957863 2485.404097000014 160.0 1.2829539720609482 0.0 490 880 950 1300 1900 2500 2500 2500 2500 2500 2500 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
POST /dynamique/session/ 30 0 520.0 820.3041638000003 25.044062000006303 3904.122808000011 45.0 1.0402329503196877 0.0 590 840 1200 1400 1600 1800 3900 3900 3900 3900 3900 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
POST /dynamique/session/bulk 26 0 670.0 845.3436738846083 19.51057700000547 2405.772530999968 411.0 0.901535223610396 0.0 710 1200 1300 1500 1700 2100 2400 2400 2400 2400 2400 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
GET /dynamique/status/ 34 0 860.0 896.2888863529417 16.754810999998426 1974.540375000004 268.3529411764706 1.1789306770289794 0.0 880 1100 1400 1500 1700 2000 2000 2000 2000 2000 2000 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
POST /dynamique/status/ 15 0 1200.0 994.8448387333392 32.91344300004084 1801.8653820000168 45.0 0.5201164751598438 0.0 1200 1500 1500 1500 1500 1800 1800 1800 1800 1800 1800 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
GET /dynamique/status/FRALLEGO002006P3 22 0 600.0 739.2469462727279 29.30853999998817 1833.3701710000128 263.54545454545456 0.7628374969011043 0.0 670 860 1100 1200 1500 1700 1800 1800 1800 1800 1800 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
GET /dynamique/status/FRALLEGO002006P3/history 28 0 920.0 1006.669206428571 36.350525999978345 3135.9566449999647 35678.28571428572 0.9708840869650418 0.0 1000 1200 1500 1500 1700 2100 3100 3100 3100 3100 3100 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
POST /dynamique/status/bulk 26 0 890.0 1076.1417643846278 53.0381039999952 2699.9636250000094 411.0 0.901535223610396 0.0 890 1400 1500 1500 1800 2500 2700 2700 2700 2700 2700 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
POST /statique/ 25 2 900.0 845.297032320002 26.081735999980538 2066.36125600005 64.24 0.8668607919330731 0.0693488633546458 900 1100 1300 1800 1800 2100 2100 2100 2100 2100 2100 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
GET /statique/?limit=10 21 0 940.0 1078.7316337142856 25.135142000010543 2047.5036729999945 13826.714285714286 0.7281630652237814 0.0 940 1400 1700 1700 1800 2000 2000 2000 2000 2000 2000 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
GET /statique/?limit=100 23 0 1100.0 1269.6886542173888 171.0780099999738 3454.0869240000234 129006.69565217392 0.7975119285784272 0.0 1100 1700 1800 1900 2100 3200 3500 3500 3500 3500 3500 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
PUT /statique/FR073EP7QU5233 34 0 680.0 770.6433103823559 40.629376000026696 2094.336771999963 1371.0 1.1789306770289794 0.0 750 830 970 1200 1400 1900 2100 2100 2100 2100 2100 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
GET /statique/FRALLEGO002006P3 15 0 830.0 915.7654820666568 28.815434000023288 1854.8093929999825 1202.0 0.5201164751598438 0.0 830 1100 1500 1600 1700 1900 1900 1900 1900 1900 1900 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
POST /statique/bulk 32 0 1000.0 1147.8425900937507 372.8875369999969 2698.1001810000294 1114.71875 1.1095818136743334 0.0 1100 1500 1500 1600 1900 2400 2700 2700 2700 2700 2700 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0
Aggregated 368 2 830.0 925.9568148668482 16.754810999998426 3904.122808000011 11963.76902173913 12.760190857254836 0.0693488633546458 830 1100 1400 1500 1800 2100 2500 3100 3900 3900 3900 d921596 2024-12-04 16:27:12.957344+00:00 0.15.0

Comparison with the latest previous benchmark

A lower (negative) value means the current version performs better than the previous one.

Type Name Request Count Failure Count Median Response Time Average Response Time Min Response Time Max Response Time Average Content Size Requests/s
GET /auth/whoami -412 0 449.0 530.3922684911796 23.82009100659843 936.4710179994518 0.0 -14.219896378173978
GET /statique/?limit=10 -385 0 330.0 510.5570863446966 9.589021006604522 2306.773908012019 -13777.0 -13.28868218408453
GET /statique/?limit=100 -398 0 350.0 393.6512227734179 -77.08641601118416 597.5702280143757 -128591.0 -13.73812746792548
Aggregated -1254 0 640.0 581.3208177121087 13.729142006638995 166.33807201441186 -46707.43743149434 -43.29249749914604

@jmaupetit jmaupetit marked this pull request as ready for review December 4, 2024 16:28
@jmaupetit jmaupetit merged commit d4f7992 into main Dec 4, 2024
23 of 24 checks passed
@jmaupetit jmaupetit deleted the fix-bench-ci branch December 4, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant