🐛(dashboard) adjust manager order in Consent model #306
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssorin
added
bug
Reordered `objects` and `active_objects` in the Consent model to ensure compatibility with Django admin expectations. Introduce a test to ensure the default Django manager is used in the admin setup, avoiding issues with custom managers.
ssorin
force-pushed
the
fix/dashboard/default-consent-manager
branch
from
13ab6b6 to
a557657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Django adminis sensitive to the order ofmodel managerdeclarations.In order to display all data in the admin, it is important to use django's default model manager.
Proposal
objectsandactive_objectsin the Consent model to ensure compatibility with Django admin expectations.