Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§‘β€πŸ’»(dashboard) add bootstrap and reset commands for dashboard setup #317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ssorin
Copy link
Collaborator

@ssorin ssorin commented Dec 20, 2024

Purpose

The bootstrap command in the makefile is too general and long to execute for working on the dashboard project alone. A specific bootstrap command for the dashboard project would be welcome.

Proposal

  • Add bootstrap-dashboard command in the Makefile to simplify project setup.
  • Add reset-dashboard-db command in the Makefile to simplify database resetting.
  • Update the dashboard README.

Introduce `bootstrap-dashboard` and `reset-dashboard-db` commands in the Makefile to streamline project setup and database resetting.
Update the dashboard README with corresponding instructions for better developer onboarding.
@ssorin ssorin added feature needs review dashboard Item related to the Dashboard service labels Dec 20, 2024
@ssorin ssorin requested a review from jmaupetit December 20, 2024 15:36
@ssorin ssorin self-assigned this Dec 20, 2024
@ssorin ssorin marked this pull request as ready for review December 20, 2024 15:38
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a minor remark.

I think we must do the same for all services ✨

```
make drop-dashboard-db
make reset-dashboard-db
make run-dashboard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this last one is required.

Suggested change
make run-dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Item related to the Dashboard service feature needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants