Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(dashboard) add admin actions for updating consent statuses #318

Merged
merged 1 commit into from
Jan 13, 2025
Merged

✨(dashboard) add admin actions for updating consent statuses #318

merged 1 commit into from
Jan 13, 2025

Conversation

ssorin
Copy link
Collaborator

@ssorin ssorin commented Dec 20, 2024 •
edited
Loading

Purpose

Simplify updating consent status (awaiting and revoked) directly from the admin interface.

Proposal

  • Add make_revoked action to the admin interface
  • Add make_awaiting action to the admin interface
  • Updates include relevant timestamps and user feedback via success messages.
  • Add test

@ssorin ssorin added feature WIP dashboard Item related to the Dashboard service labels Dec 20, 2024
@ssorin ssorin self-assigned this Dec 20, 2024
@ssorin ssorin force-pushed the feature/dashboard/revoked-admin-action branch 2 times, most recently from 4af4789 to d3a040d Compare January 8, 2025 14:02
@ssorin ssorin added needs review and removed WIP labels Jan 8, 2025
@ssorin ssorin force-pushed the feature/dashboard/revoked-admin-action branch 5 times, most recently from ee471c2 to fb67ce2 Compare January 8, 2025 16:59
@ssorin ssorin requested a review from jmaupetit January 8, 2025 17:00
@ssorin ssorin marked this pull request as ready for review January 8, 2025 17:00
@ssorin ssorin force-pushed the feature/dashboard/revoked-admin-action branch 3 times, most recently from 7b9fb34 to c84efe9 Compare January 9, 2025 16:50
jmaupetit
jmaupetit approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a minor comment.

src/dashboard/apps/consent/tests/test_admin.py Show resolved Hide resolved
src/dashboard/apps/consent/tests/test_admin.py Show resolved Hide resolved
@ssorin ssorin force-pushed the feature/dashboard/revoked-admin-action branch from c84efe9 to 4db7855 Compare January 13, 2025 10:33
@ssorin
✨(dashboard) add admin actions for updating consent statuses
1d912df 
Introduce `make_revoked` and `make_awaiting` actions to simplify updating consent status directly from the admin interface.
Updates include relevant timestamps and user feedback via success messages.
@ssorin ssorin force-pushed the feature/dashboard/revoked-admin-action branch from 4db7855 to 1d912df Compare January 13, 2025 10:34
@ssorin ssorin merged commit 813d72f into main Jan 13, 2025
10 checks passed
@ssorin ssorin deleted the feature/dashboard/revoked-admin-action branch January 13, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaupetit jmaupetit jmaupetit approved these changes

Assignees

@ssorin ssorin

Labels
dashboard Item related to the Dashboard service feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssorin @jmaupetit