-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: migrate database enum from name to value (2) #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
added
improvement
schema
Discussions around data schemas
API
Item related to the API service
labels
Jan 23, 2025
jmaupetit
force-pushed
the
api-migrate-enums-2
branch
2 times, most recently
from
January 23, 2025 14:50
614fc2d
to
a38cbbd
Compare
Now that we moved legacy enum (with keys) to a varchar column, we update enum keys to their corresponding values and switch back columns to the new enum (with values).
jmaupetit
force-pushed
the
api-migrate-enums-2
branch
from
January 23, 2025 16:21
a38cbbd
to
9ba6fea
Compare
Current benchmark
Comparison with the latest previous benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
By default, python-derived enum fields are stored using the enum name instead of its value in database. This forces us to map the corresponding value when exporting data.
Proposal
Now that we moved legacy enum (with keys) to a varchar column, we update enum keys to their corresponding values and switch back columns to the new enum (with values).
This is the second step of the database migration (for the first step, see #351).
We also had to fix previous migration in #354